chore(keyring-controller): deprecate KeyringTypes#8907
Merged
Conversation
hmalik88
previously approved these changes
May 27, 2026
KeyringTypes
hmalik88
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Deprecating
KeyringTypesin favor of the new v2 type.References
N/A
Checklist
Note
Low Risk
Documentation-only deprecation with no removal or behavior change; consumers keep compiling against the existing enum until a future major release.
Overview
Marks the exported
KeyringTypesenum in@metamask/keyring-controlleras deprecated via JSDoc, steering integrators towardKeyringTypefrom@metamask/keyring-api/v2(and the v2KeyringTypeswhere a V2 builder exists). The enum values and runtime behavior are unchanged.The package changelog records the deprecation under Unreleased, aligned with the recent breaking move of
withKeyringV2selectors to v2 types.Reviewed by Cursor Bugbot for commit b472f9a. Bugbot is set up for automated code reviews on this repo. Configure here.