Skip to content

chore(keyring-controller): deprecate KeyringTypes#8907

Merged
ccharly merged 2 commits into
mainfrom
cc/chore/deprecate-KeyringTypes
May 27, 2026
Merged

chore(keyring-controller): deprecate KeyringTypes#8907
ccharly merged 2 commits into
mainfrom
cc/chore/deprecate-KeyringTypes

Conversation

@ccharly
Copy link
Copy Markdown
Contributor

@ccharly ccharly commented May 27, 2026

Explanation

Deprecating KeyringTypes in favor of the new v2 type.

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Documentation-only deprecation with no removal or behavior change; consumers keep compiling against the existing enum until a future major release.

Overview
Marks the exported KeyringTypes enum in @metamask/keyring-controller as deprecated via JSDoc, steering integrators toward KeyringType from @metamask/keyring-api/v2 (and the v2 KeyringTypes where a V2 builder exists). The enum values and runtime behavior are unchanged.

The package changelog records the deprecation under Unreleased, aligned with the recent breaking move of withKeyringV2 selectors to v2 types.

Reviewed by Cursor Bugbot for commit b472f9a. Bugbot is set up for automated code reviews on this repo. Configure here.

@ccharly ccharly requested review from a team as code owners May 27, 2026 13:22
@ccharly ccharly temporarily deployed to default-branch May 27, 2026 13:23 — with GitHub Actions Inactive
hmalik88
hmalik88 previously approved these changes May 27, 2026
@ccharly ccharly enabled auto-merge May 27, 2026 13:23
@ccharly ccharly changed the title chore(keyring-controller): deprecate KeyringTypes chore(keyring-controller): deprecate KeyringTypes May 27, 2026
@ccharly ccharly added this pull request to the merge queue May 27, 2026
Merged via the queue into main with commit f12223d May 27, 2026
370 checks passed
@ccharly ccharly deleted the cc/chore/deprecate-KeyringTypes branch May 27, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants